Hello, We are currently testing Havana python-{cinder,nova,keystone}client rpms and we noticed that completion files have been moved to /etc/profile.d. This is causing the following errors in zsh shells and, as a consequence, it's blocking the deployment in production. /etc/profile.d/cinder.sh:15: command not found: complete /etc/profile.d/keystone.sh:27: command not found: complete /etc/profile.d/nova.sh:27: command not found: complete Wouldn't be better to have some kind of guard at the beginning of those files like "[ -z "$BASH_VERSION" ] && return" to avoid the execution on non-bash shells?

[Adding Jakub Ruzicka who intially pointed this issue.] On 01/27/2014 04:21 PM, Stefano Zilli wrote: > Hello, > > We are currently testing Havana python-{cinder,nova,keystone}client rpms and we noticed that completion files have been moved to /etc/profile.d. > This is causing the following errors in zsh shells and, as a consequence, it's blocking the deployment in production. > > /etc/profile.d/cinder.sh:15: command not found: complete > /etc/profile.d/keystone.sh:27: command not found: complete > /etc/profile.d/nova.sh:27: command not found: complete > > Wouldn't be better to have some kind of guard at the beginning of those files like "[ -z "$BASH_VERSION" ] && return" to avoid the execution on non-bash shells? Right, sane thing to do is to place them in /etc/bash_completion.d, which requires bash-completion package, to avoid such errors.