9:35 p.m.
Hi all,
We find some of the openstack systemd config contain "Restart=always", but some
other do not have this, is this a bug or this is just what we want?
Thanks for your help.
For example:
We have "Restart=always" in keystone:
[cid:image002.jpg@01D0DBFD.205589F0]
But we do not have "Restart=always" in neutron-server:
[cid:image004.jpg@01D0DBFD.205589F0]
Thanks.
Regards,
Liping Mao
9:42 a.m.
I +1 that issue. I've noticed large differences in the systemd config units for many
services, often without specific functional needs.
I'd think that "Restart=always" is a good setting for all services. What it
really brings up is maybe the issue of streamlining the unit config files.
Regards,
Daniel Speichert
From: "Liping Mao (limao)" <limao(a)cisco.com>
To: "rdo-list" <rdo-list(a)redhat.com>
Sent: Thursday, August 20, 2015 10:35:42 PM
Subject: [Rdo-list] Question about Restart=always in systemd
Hi all,
We find some of the openstack systemd config contain “Restart=always”, but some other do
not have this, is this a bug or this is just what we want?
Thanks for your help.
For example:
We have “Restart=always” in keystone:
But we do not have “Restart=always” in neutron-server:
Thanks.
Regards,
Liping Mao
_______________________________________________
Rdo-list mailing list
Rdo-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/rdo-list
To unsubscribe: rdo-list-unsubscribe(a)redhat.com
3:38 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 08/21/2015 04:42 PM, Daniel Speichert wrote:
I +1 that issue. I've noticed large differences in the systemd
config units for many services, often without specific functional
needs. I'd think that "Restart=always" is a good setting for all
services. What it really brings up is maybe the issue of
streamlining the unit config files.
Totally agreed we need to streamline .service files. I think the root
of the problem here is that we don't generate those files but
copy-paste them and modify to each new need.
I believe a better approach would be to follow what e.g. Debian folks
do to support their runlevel manager complexity:
http://thomas.goirand.fr/blog/?p=212
I don't believe this should be tackled by one each package team
separately, and instead requires some form of coordination and
heavy-lifting from people that are involved in the core RDO matters.
Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJV2tgGAAoJEC5aWaUY1u57QqQH/1gmD24fqkY7G+6ffdUcgh1T
V1B4vamr6J3p8Mzfm1lWz56JXF+IZk/XWOlureCBcQZbZnFlRM6dHjNf+NCoE6Px
YM1JEMdwjBuDfWYGFWLDv9kxKR9iM7xVQLO9nt/MzZV2nt85coCwXFHGnufU8vOO
F6xHKc78mNJGxCl6wudxb23bt+N9/SUzpnUke4kJaaKRaHP6LuJZ1+Kq0dtfS+zC
UdzwcB7NvxyyVVh7nIrDjIS/lwLdbxDGP+Obax4PZSQZbkctt+B0Z4/B521x/K6f
wreGoRQAcoh5D1neVW8dMCvNTjZXD/3hG6GmwkiJDZe8rKJvfhmGzNGF+3K7hN0=
=Jh9c
-----END PGP SIGNATURE-----
10:17 a.m.
On Fri, Aug 21, 2015 at 04:42:30PM +0200, Daniel Speichert wrote:
I +1 that issue. I've noticed large differences in the systemd
config
units for many services, often without specific functional needs.
I'd think that "Restart=always" is a good setting for all services.
What it really brings up is maybe the issue of streamlining the unit
config files.
For several releases, we've had packaging guidelines in Fedora
encouraging Restart=on-failure or Restart=on-abnormal:
https://fedoraproject.org/wiki/Packaging:Systemd#Automatic_restarting
We never, however, had an effort to bring existing packages into a
consistent state. I'd love for that effort to happen — anyone
interesting in helping out?
--
Matthew Miller mattdm(a)mattdm.org <http://mattdm.org/>
Fedora Project Leader mattdm(a)fedoraproject.org <http://fedoraproject.org/>
10:32 a.m.
On Fri, Sep 04, 2015 at 11:17:16AM -0400, Matthew Miller wrote:
> I'd think that "Restart=always" is a good setting
for all services.
> What it really brings up is maybe the issue of streamlining the unit
> config files.
For several releases, we've had packaging guidelines in Fedora
encouraging Restart=on-failure or Restart=on-abnormal:
https://fedoraproject.org/wiki/Packaging:Systemd#Automatic_restarting
We never, however, had an effort to bring existing packages into a
consistent state. I'd love for that effort to happen — anyone
interesting in helping out?
And then there were crickets. :)
--
Matthew Miller mattdm(a)mattdm.org <http://mattdm.org/>
Fedora Project Leader mattdm(a)fedoraproject.org <http://fedoraproject.org/>
11:37 a.m.
On Fri, Sep 11, 2015 at 11:32:14AM -0400, Matthew Miller wrote:
On Fri, Sep 04, 2015 at 11:17:16AM -0400, Matthew Miller wrote:
> > I'd think that "Restart=always" is a good setting for all
services.
> > What it really brings up is maybe the issue of streamlining the unit
> > config files.
>
> For several releases, we've had packaging guidelines in Fedora
> encouraging Restart=on-failure or Restart=on-abnormal:
>
> https://fedoraproject.org/wiki/Packaging:Systemd#Automatic_restarting
>
> We never, however, had an effort to bring existing packages into a
> consistent state. I'd love for that effort to happen — anyone
> interesting in helping out?
And then there were crickets. :)
I didn't see any other traffic on this, so...
How about a mechanism to *generate* unit files using information
specified by the package? Maybe packages would provide "stub" unit
files that contain only things that differ from standard behavior
(e.g., description, dependencies, environmentfiles, etc), and then the
actual unit file is generated by filling in the missing information.
E.g., for openstack-nova, a package provides the following stub:
[Service]
Type=notify
NotifyAcess=all
TimeoutStartSec=0
User=nova
And then you run:
install-systemd-unit \
--execstart /usr/bin/nova-api \
--description "OpenStack Nova API Server" \
/path/to/stub/units/openstack-nova-template.service \
/lib/systemd/system/openstack-nova-api.service
And you get:
[Unit]
Description=OpenStack Nova API Server
After=syslog.target network.target
[Service]
Type=notify
NotifyAccess=all
User=nova
ExecStart=/usr/bin/nova-api
Restart=on-failure
[Install]
WantedBy=multi-user.target
And for, say, openstack-nova-scheduler:
install-systemd-unit \
--execstart /usr/bin/nova-scheduler \
--description "OpenStack Nova Scheduler Server" \
/path/to/stub/units/openstack-nova-template.service \
/lib/systemd/system/openstack-nova-scheduler.service
Or if that's too crazy, just add a check to the fedora-review tool
that ensures unit files have standard settings, such as the Restart=
setting. The review could flag things like:
- Missing Restart behavior
- Missing Description
Either solution would be reasonably easy to put together. I like the
first one, because (a) yay automation and because (b) it would allow
for local policy overrides ("I want all my services to run with
Restart=always instead of Restart=on-failure").
An auditing tool could also be used to check all of the *existing*
packages, if that were preferable in addition to or as an alternative
too either of the above.
--
Lars Kellogg-Stedman <lars(a)redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack | http://blog.oddbit.com/
1:33 p.m.
2015-09-15 18:37 GMT+02:00 Lars Kellogg-Stedman <lars(a)redhat.com>:
On Fri, Sep 11, 2015 at 11:32:14AM -0400, Matthew Miller wrote:
> On Fri, Sep 04, 2015 at 11:17:16AM -0400, Matthew Miller wrote:
> > > I'd think that "Restart=always" is a good setting for all
services.
> > > What it really brings up is maybe the issue of streamlining the unit
> > > config files.
> >
> > For several releases, we've had packaging guidelines in Fedora
> > encouraging Restart=on-failure or Restart=on-abnormal:
> >
> > https://fedoraproject.org/wiki/Packaging:Systemd#Automatic_restarting
> >
> > We never, however, had an effort to bring existing packages into a
> > consistent state. I'd love for that effort to happen — anyone
> > interesting in helping out?
>
> And then there were crickets. :)
I didn't see any other traffic on this, so...
How about a mechanism to *generate* unit files using information
specified by the package? Maybe packages would provide "stub" unit
files that contain only things that differ from standard behavior
(e.g., description, dependencies, environmentfiles, etc), and then the
actual unit file is generated by filling in the missing information.
E.g., for openstack-nova, a package provides the following stub:
[Service]
Type=notify
NotifyAcess=all
TimeoutStartSec=0
User=nova
And then you run:
install-systemd-unit \
--execstart /usr/bin/nova-api \
--description "OpenStack Nova API Server" \
/path/to/stub/units/openstack-nova-template.service \
/lib/systemd/system/openstack-nova-api.service
And you get:
[Unit]
Description=OpenStack Nova API Server
After=syslog.target network.target
[Service]
Type=notify
NotifyAccess=all
User=nova
ExecStart=/usr/bin/nova-api
Restart=on-failure
[Install]
WantedBy=multi-user.target
And for, say, openstack-nova-scheduler:
install-systemd-unit \
--execstart /usr/bin/nova-scheduler \
--description "OpenStack Nova Scheduler Server" \
/path/to/stub/units/openstack-nova-template.service \
/lib/systemd/system/openstack-nova-scheduler.service
Not a bad idea, could be a feature for Fedora 24 (systemd-unit-utils)
/me adds this on his TODO
Could be a RPM macro but it would be very ugly.
Or if that's too crazy, just add a check to the fedora-review
tool
that ensures unit files have standard settings, such as the Restart=
setting. The review could flag things like:
- Missing Restart behavior
- Missing Description
Easy fix.
Either solution would be reasonably easy to put together. I like
the
first one, because (a) yay automation and because (b) it would allow
for local policy overrides ("I want all my services to run with
Restart=always instead of Restart=on-failure").
An auditing tool could also be used to check all of the *existing*
packages, if that were preferable in addition to or as an alternative
too either of the above.
--
Lars Kellogg-Stedman <lars(a)redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack | http://blog.oddbit.com/
_______________________________________________
Rdo-list mailing list
Rdo-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/rdo-list
To unsubscribe: rdo-list-unsubscribe(a)redhat.com
3:30 p.m.
On Tue, Sep 15, 2015 at 08:33:16PM +0200, Haïkel wrote:
> Or if that's too crazy, just add a check to the
fedora-review tool
> that ensures unit files have standard settings, such as the Restart=
> setting. The review could flag things like:
>
> - Missing Restart behavior
> - Missing Description
As a proof-of-concept for this sort of idea:
https://github.com/larsks/audit-unit-files
Which, when run for example against the delorean nova repository:
git clone https://github.com/openstack-packages/nova.git
find nova -name '*.service' |
xargs audit-unit-files -r required.service -a
Yields:
ERROR:__main__:file nova/openstack-nova-serialproxy.service is missing required option
Service/restart
ERROR:__main__:file nova/openstack-nova-xvpvncproxy.service is missing required option
Service/restart
ERROR:__main__:file nova/openstack-nova-novncproxy.service is missing required option
Service/restart
ERROR:__main__:file nova/openstack-nova-spicehtml5proxy.service is missing required
option Service/restart
(Run with '-v' to report 'file is okay' for files with no errors)
--
Lars Kellogg-Stedman <lars(a)redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack | http://blog.oddbit.com/
3143
days inactive
3170
days old
7 comments
7 participants
participants (7)
-
Daniel Speichert -
Haïkel -
Ihar Hrachyshka -
Lars Kellogg-Stedman -
Liping Mao (limao) -
Matthew Miller -
Matthew Miller