3:59 a.m.
Hi,
From what I see, "cinder retype” does not work with different QoS
types yet, correct?
Thanks!
Arne
--
Arne Wiebalck
CERN IT
4:33 a.m.
On Wed, Nov 19, 2014 at 09:59:46AM +0000, Arne Wiebalck wrote:
Hi,
>From what I see, "cinder retype” does not work with different QoS
>types yet, correct?
I'm not a Cinder expert, but looking at the change[1] that introduced
the Cinder volume retype functionality, at end of the commit message, it
says:
[. . .]
This version will cause retype operations to fail if the current and
new volume types have different:
1. QoS settings that are enforced by the front-end for in-use volumes.
2. encryption settings.
Not sure if that (point 1 there) answers your question.
[1] https://review.openstack.org/#/c/44881/ -- Add ability to modify
volume type
--
/kashyap
4:42 a.m.
On 19 Nov 2014, at 11:33, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
On Wed, Nov 19, 2014 at 09:59:46AM +0000, Arne Wiebalck wrote:
> Hi,
>
>> From what I see, "cinder retype” does not work with different QoS
>> types yet, correct?
I'm not a Cinder expert, but looking at the change[1] that introduced
the Cinder volume retype functionality, at end of the commit message, it
says:
[. . .]
This version will cause retype operations to fail if the current and
new volume types have different:
1. QoS settings that are enforced by the front-end for in-use volumes.
2. encryption settings.
Not sure if that (point 1 there) answers your question.
[1] https://review.openstack.org/#/c/44881/ -- Add ability to modify
volume type
Thanks. I saw that change. This and packstack tells me it does not work, at least
for a Ceph based backend :) Also the Cinder code (retype being empty in driver.py
and not being overwritten rbd.py points) in that direction.
http://redhatstackblog.redhat.com/2014/04/15/whats-new-in-icehouse-storage/
gives a slightly different impression IMHO.
Cheers,
Arne
--
Arne Wiebalck
CERN IT
6:51 a.m.
On Wed, Nov 19, 2014 at 10:42:42AM +0000, Arne Wiebalck wrote:
On 19 Nov 2014, at 11:33, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
> On Wed, Nov 19, 2014 at 09:59:46AM +0000, Arne Wiebalck wrote:
>> Hi,
>>
>>> From what I see, "cinder retype” does not work with different QoS
>>> types yet, correct?
>
> I'm not a Cinder expert, but looking at the change[1] that introduced
> the Cinder volume retype functionality, at end of the commit message, it
> says:
>
> [. . .]
> This version will cause retype operations to fail if the current and
> new volume types have different:
> 1. QoS settings that are enforced by the front-end for in-use volumes.
> 2. encryption settings.
>
> Not sure if that (point 1 there) answers your question.
>
>
> [1] https://review.openstack.org/#/c/44881/ -- Add ability to modify
> volume type
Thanks. I saw that change. This and packstack tells me it does not
work, at least for a Ceph based backend :)
Hmm, let's see if any Packstack/Cinder developers will weigh in here.
Also the Cinder code (retype being empty in driver.py and not being
overwritten rbd.py points) in that direction.
http://redhatstackblog.redhat.com/2014/04/15/whats-new-in-icehouse-storage/
gives a slightly different impression IMHO.
I cannot speak for the author of that post, but probably it's talking
about what's in the upstream. :-)
--
/kashyap
8:20 a.m.
On 19 Nov 2014, at 13:51, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
[snip]
> Thanks. I saw that change. This and packstack tells me it does
not
> work, at least for a Ceph based backend :)
Hmm, let's see if any Packstack/Cinder developers will weigh in here.
> Also the Cinder code (retype being empty in driver.py and not being
> overwritten rbd.py points) in that direction.
>
> http://redhatstackblog.redhat.com/2014/04/15/whats-new-in-icehouse-storage/
> gives a slightly different impression IMHO.
I cannot speak for the author of that post, but probably it's talking
about what's in the upstream. :-)
From what I understand, retype needs to be implemented on a per driver
level, and that’s simply not the case for the rbd driver yet.
Below is a small patch to the rbd driver that “implements” the retype function
and subsequently allows for QoS changes of Cinder volumes on Ceph.
(Not sure at all if that breaks things elsewhere :)
—>
# diff -u /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py.orig
/usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py
--- /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py.orig 2014-11-19
11:44:43.739979396 +0100
+++ /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py 2014-11-19
14:28:27.853345650 +0100
@@ -651,6 +651,29 @@
new_name = "%s.deleted" % (volume_name)
self.rbd.RBD().rename(client.ioctx, volume_name, new_name)
+ def retype(self, ctxt, volume, new_type, diff, host):
+ """Retype a volume, QoS change only."""
+ LOG.info('Retype volume request %(vol)s to be %(type)s '
+ '(host: %(host)s), diff %(diff)s.' %
+ {'vol': volume['name'],
+ 'type': new_type,
+ 'host': host,
+ 'diff': diff})
+
+ if volume['host'] != host['host']:
+ LOG.error('Retype with host migration not supported')
+ return False
+
+ if diff['encryption']:
+ LOG.error('Retype of encryption type not supported')
+ return False
+
+ if diff['extra_specs']:
+ LOG.error('Retype of extra_specs not supported')
+ return False
+
+ return True
+
<--
Cheers,
Arne
--
Arne Wiebalck
CERN IT
11:36 a.m.
[. . .]
From what I understand, retype needs to be implemented on a per
driver
level, and that’s simply not the case for the rbd driver yet.
Below is a small patch to the rbd driver that “implements” the retype
function
and subsequently allows for QoS changes of Cinder volumes on Ceph.
(Not sure at all if that breaks things elsewhere :)
If you have time, you might want to submit an upstream review
request and let the CI infrastructure handle that for you.
--
/kashyap
—>
# diff -u /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py.orig
/usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py
--- /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py.orig
2014-11-19 11:44:43.739979396 +0100
+++ /usr/lib/python2.6/site-packages/cinder/volume/drivers/rbd.py 2014-11-19
14:28:27.853345650 +0100
@@ -651,6 +651,29 @@
new_name = "%s.deleted" % (volume_name)
self.rbd.RBD().rename(client.ioctx, volume_name, new_name)
+ def retype(self, ctxt, volume, new_type, diff, host):
+ """Retype a volume, QoS change only."""
+ LOG.info('Retype volume request %(vol)s to be %(type)s '
+ '(host: %(host)s), diff %(diff)s.' %
+ {'vol': volume['name'],
+ 'type': new_type,
+ 'host': host,
+ 'diff': diff})
+
+ if volume['host'] != host['host']:
+ LOG.error('Retype with host migration not supported')
+ return False
+
+ if diff['encryption']:
+ LOG.error('Retype of encryption type not supported')
+ return False
+
+ if diff['extra_specs']:
+ LOG.error('Retype of extra_specs not supported')
+ return False
+
+ return True
+
<--
Cheers,
Arne
--
Arne Wiebalck
CERN IT
1:51 a.m.
On 19 Nov 2014, at 18:36, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
[. . .]
> From what I understand, retype needs to be implemented on a per driver
> level, and that’s simply not the case for the rbd driver yet.
>
> Below is a small patch to the rbd driver that “implements” the retype
> function
> and subsequently allows for QoS changes of Cinder volumes on Ceph.
>
> (Not sure at all if that breaks things elsewhere :)
If you have time, you might want to submit an upstream review
request and let the CI infrastructure handle that for you.
Done:
https://review.openstack.org/#/c/135874/
Cheers,
Arne
--
Arne Wiebalck
CERN IT
3:54 a.m.
On Thu, Nov 20, 2014 at 07:51:40AM +0000, Arne Wiebalck wrote:
On 19 Nov 2014, at 18:36, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
> [. . .]
>
>> From what I understand, retype needs to be implemented on a per
>> driver level, and that’s simply not the case for the rbd driver
>> yet.
>>
>> Below is a small patch to the rbd driver that “implements” the
>> retype function and subsequently allows for QoS changes of Cinder
>> volumes on Ceph.
>>
>> (Not sure at all if that breaks things elsewhere :)
>
> If you have time, you might want to submit an upstream review
> request and let the CI infrastructure handle that for you.
Done: https://review.openstack.org/#/c/135874/
Nice. It needs a respin -- PEP-8 indentation errors, commented in the
review.
--
/kashyap
7:37 a.m.
On 19/Nov/2014 @ 10:42, Arne Wiebalck wrote:
On 19 Nov 2014, at 11:33, Kashyap Chamarthy <kchamart(a)redhat.com> wrote:
> On Wed, Nov 19, 2014 at 09:59:46AM +0000, Arne Wiebalck wrote:
>> Hi,
>>
>>> From what I see, "cinder retype” does not work with different QoS
>>> types yet, correct?
>
> I'm not a Cinder expert, but looking at the change[1] that introduced
> the Cinder volume retype functionality, at end of the commit message, it
> says:
>
> [. . .]
> This version will cause retype operations to fail if the current and
> new volume types have different:
> 1. QoS settings that are enforced by the front-end for in-use volumes.
> 2. encryption settings.
>
> Not sure if that (point 1 there) answers your question.
>
>
> [1] https://review.openstack.org/#/c/44881/ -- Add ability to modify
> volume type
Thanks. I saw that change. This and packstack tells me it does not work ...
Can you give me more information about this statement ?
--
Gaël Chamoulaud
Openstack Engineering
Mail: [gchamoul|gael] at redhat dot com
IRC: strider/gchamoul (Red Hat), gchamoul (Freenode)
GnuPG Key ID: 7F4B301
C75F 15C2 A7FD EBC3 7B2D CE41 0077 6A4B A7F4 B301
Freedom...Courage...Commitment...Accountability
3442
days inactive
3444
days old
8 comments
3 participants
participants (3)
-
Arne Wiebalck -
Gaël Chamoulaud -
Kashyap Chamarthy