7:52 a.m.
2016-07-26 12:33 GMT+02:00 Mark McLoughlin <markmc(a)redhat.com>:
On Tue, Jul 26, 2016 at 1:04 AM, Honza Pokorny
<honza(a)redhat.com> wrote:
> On 2016-07-25 16:23, Haïkel wrote:
>> 2016-07-25 16:17 GMT+02:00 Honza Pokorny <honza(a)redhat.com>:
>> > On 2016-07-23 04:26, Haďkel wrote:
>> >> @Jason: As I said during the mentioned call, we have nodejs 0.10.36
>> >> build in CBS -I'm actually the one who built it- and there's no
>> >> problem in importing a LTS release (4.x or 6.x)
>> >> Mattias is of the opinion we should stick to 4.x which is the current
LTS.
>> >> http://cbs.centos.org/koji/buildinfo?buildID=8185
>> >>
>> >> I'm taking the action of importing a newer nodejs build in our
>> >> repository. Jakub and I will be providing support in
>> >> packaging/reviewing tripleo-ui.
>> >
>> > I'm confident we can make this happen early this week, thanks to Haikel
>> > and Jakup. As Jason said, if we can get some eyes on the infra patch
>> > and the packaging patch that would certainly speed things up.
>> >
>> > Haikel, if you could have a quick look at the spec file for tripleo-ui,
>> > I think that would make a nice starting point. Or, would you rather I
>> > submitted a format request for review to RDO at this point?
>> >
>>
>> Both works for me.
>
> RDO review request: https://bugzilla.redhat.com/show_bug.cgi?id=1359950
>
> Gerrit patch: https://review.openstack.org/#/c/344932/
Thanks, Honza.
Just looking through the node_modules tarball very briefly, I think
it's going to take quite a bit of review to satisfy ourselves that
everything is really built from source in the build system, and that
we will actually be able to %patch the source for anything shipped in
the final RPM or anything used to build an artifact in the final RPM.
For a start, I suggest deleting phantomjs-prebuilt and see what
happens. It contains an ELF executable.
This is the only ELF binary, and it's only required for running tests,
so we can drop it.
Another good reason is that rebuilding recent webkit on EL7 would take
some time.
node_modules.tar.gz should be in a separate tarballs, in order for us
to include tripleo-ui in DLRN.
Many libs are generated from coffeescript (800 exactly), some libs are
duplicated (e.g lodash, source-map, express, base64 etc.) but fighting
duplication will be a never-ending task with node apps.
First licensing checks:
* React.js: should be ok but patents grant is still debated among legal
* known licenses: MIT, BSD 2 and 3 clauses, ISC, WTFPL 2.0, ASL 2.0,
MPL 2.0 (w/ BSD 3 clauses which saves the hassle to figure out
compatibility w/ GPL)
* unknown licenses: mostly generated files from coffeescript.
Regards,
H.
Another minor observation - the tarball published by upstream should
have a tripleo-ui-$version base directory.
Mark.
>> >> Considering we'll be having many missing people due to summer
>> >> vacations, I associated Jakub to avoid being the SPOF in that process.
>> >>
>> >> As we want to have this sorted out before M3, I'd like to have
status
>> >> during our weekly RDO meetings to follow up progress and solve
>> >> impediments.
>> >>
>> >> Regards,
>> >> H.
>
> _______________________________________________
> rdo-list mailing list
> rdo-list(a)redhat.com
> https://www.redhat.com/mailman/listinfo/rdo-list
>
> To unsubscribe: rdo-list-unsubscribe(a)redhat.com