[Rdo-list] [tripleo-quickstart] Patches and more patches

[John Trowbridge]

On 03/21/2016 12:00 AM, David Moreau Simard wrote:
> Let me preface this by pleading my ignorance about a lot of things TripleO.
> 
> There seems to be a lot of interest, traction and improvements to
> quickstart recently. That's awesome in a lot of ways.
> 
> Are we taking steps to ensure that relevant things are sent upstream ? I
> know there is a spec right now to send it mostly as-is upstream.
> What I mean is if we are making sure we are not working around things that
> should be done properly or fixed in THT, Instack-Undercloud or other
> TripleO components.
> 

I fully agree that tripleo-quickstart should funnel improvements
upstream, and not hide bugs via workarounds. Right now, there is only
one workaround outside of image building, which needs a separate spec
and overhaul upstream. (The image building workarounds are related to
removing the need for EPEL, and removing some DIB elements which only
have a single line of bash)

We need a 'yes hack'[1] in order to use the tripleo.sh pingtest, because
heatclient added a confirmation for stack deletion. It is protected by a
check for tty, but ansible is getting a tty.

Note, that the upstream spec[2] to replace instack-virt-setup has
multiple +2's now, so we should be able to start migrating to the
openstack namespace soon. This alone does not ensure that we don't have
fixes creep into tripleo-quickstart that should be in some other TripleO
component, but it does make it harder. (Since there will potentially be
more TripleO core involvement)

None of the many improvements from Lars below are hiding issues in
TripleO though. (They would be if we were not replacing
instack-virt-setup, but that has been the goal from day 1)

[1]
https://github.com/redhat-openstack/tripleo-quickstart/blob/master/playbooks/roles/tripleo/overcloud/templates/tripleo-pingtest.sh.j2#L19-L22
[2] https://review.openstack.org/#/c/276810/

> David Moreau Simard
> Senior Software Engineer | Openstack RDO
> 
> dmsimard = [irc, github, twitter]
> On Mar 20, 2016 5:33 PM, "Lars Kellogg-Stedman" <lars at redhat.com> wrote:
> 
>> Hello fellow tripleo-quickstarters;
>>
>> There are a pile of my patches in the queue right now, so I wanted to
>> present a summary to help sort them out.
>>
>> 266425   larsks   use nthhost filter to derive floating ip values
>>                   https://review.gerrithub.io/266425
>> 266527   larsks   derive network settings in undercloud.conf
>>                   https://review.gerrithub.io/266527
>> 266815   larsks   pingtest must respect floating ip range
>>                   https://review.gerrithub.io/266815
>>
>>   These three patches make it easier to specify an address range for
>>   the undercloud and for the floating ip networks created during
>>   overcloud validation.  They also (266815) make sure that our
>>   validation scripts respect the address range we configure.
>>
>> 266446   larsks   teach quickstart.sh about --no-clone
>>                   https://review.gerrithub.io/266446
>>
>>   This is primarily a developer optimization that makes it easier to
>>   test quickstart.sh against a local working copy (which removes the
>>   requirement of first posting changes to gerrit so they can be
>>   obtained using the '-g' flag to quickstart.sh).
>>
>> 266269   larsks   support targeting localhost
>>                   https://review.gerrithub.io/266269
>>
>>   This ensures that both "quickstart.sh some.remote.host" and
>>   "quickstart.sh localhost" will work.  Note that at the moment
>>   changes between this patch and the previous one (266446) are
>>   conflated; I'm going to try sort these out this evening.
>>
>> 266680   larsks   add overcloud hosts to /etc/hosts
>>                   https://review.gerrithub.io/266680
>> 266748   larsks   generate ssh config on undercloud
>>                   https://review.gerrithub.io/266748
>>
>>   These are convenience patches.  The first adds the names of
>>   overcloud hosts to /etc/hosts on the undercloud, and the second adds
>>   an ssh configuration on the undercloud that means you don't need to
>>   specify 'heat-admin@' when logging in to overcloud hosts.  So once
>>   logged into the undercloud, you can...
>>
>>       ssh overcloud-controller-0
>>
>>   ...and it Just Works.
>>
>> 266574   larsks   ensure local_working_dir exists
>>                   https://review.gerrithub.io/266574
>> 266633   larsks   grant libvirt access to non-root user
>>                   https://review.gerrithub.io/266633
>> 266635   larsks   ensure XDG_RUNTIME_DIR is set
>>                   https://review.gerrithub.io/266635
>>
>>   These are small maintenance packages.  The last makes sure that
>>   `virsh` will operate correctly when accessing the unprivileged user
>>   account via `su -` in addition to direct ssh access.
>>
>> --
>> Lars Kellogg-Stedman <lars at redhat.com> | larsks @
>> {freenode,twitter,github}
>> Cloud Engineering / OpenStack          | http://blog.oddbit.com/
>>
>> _______________________________________________
>> Rdo-list mailing list
>> Rdo-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/rdo-list
>>
>> To unsubscribe: rdo-list-unsubscribe at redhat.com
>>
> 
> 
> 
> _______________________________________________
> Rdo-list mailing list
> Rdo-list at redhat.com
> https://www.redhat.com/mailman/listinfo/rdo-list
> 
> To unsubscribe: rdo-list-unsubscribe at redhat.com
>