[rdo-users] requests requires chardet >= 3.0.2, < 3.1.0

[Haïkel Guémar]

On 02/10/2018 21:22, iain MacDonnell wrote:
> Not sure if this should go to -users or -dev (or somewhere else)...
> 
> RDO (Rocky) ships with python2-requests-2.19.1-3.el7.noarch.rpm and
> python2-chardet-3.0.4-7.el7.noarch.rpm.
> 
> The requests code has a hard-coded check for:
> 
>      # Check chardet for compatibility.
>      major, minor, patch = chardet_version.split('.')[:3]
>      major, minor, patch = int(major), int(minor), int(patch)
>      # chardet >= 3.0.2, < 3.1.0
>      assert major == 3
>      assert minor < 1
>      assert patch >= 2
> 
> Unfortunately this requirement is not reflected in the
> python2-requests RPM, which just "requires" "python-chardet" (without
> any specific version). If the EL7-bundled version of python-chardet is
> already installed, and one installs python2-requests from the RDO
> repo, either directly or via dependency, python2-chardet does NOT get
> updated, which results in warnings like:
> 
> # python -c 'import requests'
> /usr/lib/python2.7/site-packages/requests/__init__.py:91:
> RequestsDependencyWarning: urllib3 (1.21.1) or chardet (2.2.1) doesn't
> match a supported version!
>    RequestsDependencyWarning)
> #
> 
> I think that the python2-requests PRM needs an explicit "requires" for
> the specific version of python[2]-chardet. Anyone disagree? What's the
> right way to file a bug on this?
> 
> TIA,
> 
>      ~iain
> _______________________________________________
> users mailing list
> users at lists.rdoproject.org
> http://lists.rdoproject.org/mailman/listinfo/users
> 
> To unsubscribe: users-unsubscribe at lists.rdoproject.org
> 

FYI, I acknowledge this issue so I should deliver a fix today.
About it, we're rebasing requests packages from Fedora but it seems that 
they just dropped that lower version requirements for the same reason 
[1] so reintroducing it there would not be constructive.
Nonetheless, we will fix it in RDO packages as it impacts EL7 users.

Regards,
H.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1589306