[Rdo-list] What is missing commit "vifs: replace 'ifconfig' usage with 'ip'" from nova docker master branch ?

[Lars Kellogg-Stedman]

On Mon, Mar 09, 2015 at 12:45:45AM -0400, Boris Derzhavets wrote:
> Consider  commit 9d06520645f28d96ef905a709f8ff0c27842b58b
> in nova-docker master branch https://git.openstack.org/cgit/stackforge/nova-docker/
> 
> It does :-
> 
> - utils.execute('ip', 'netns', 'exec', container_id, 'ifconfig',
> - if_remote_name, ip, run_as_root=True)
> + utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'addr',
> + 'add', ip, 'dev', if_remote_name, run_as_root=True)
> 
> The last statement should be followed by
> 
> utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'link',
>   'set', if_remote_name,'up',run_as_root=True)

Boris,

That all sounds reasonable.  You should submit your change to the
nova-docker project by following
http://docs.openstack.org/infra/manual/developers.html.

Cheers,

-- 
Lars Kellogg-Stedman <lars at redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack          | http://blog.oddbit.com/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.rdoproject.org/pipermail/dev/attachments/20150309/42df67a9/attachment.sig>